Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, November 7, 2017 10:43 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; jblu...@infradead.org; Richardson, Bruce; Ananyev, > Konstantin; De Lara Guarch, Pablo; y...@fridaylinux.org; > maxime.coque...@redhat.com; mtetsu...@gmail.com; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to > drivers/bus > > Hi Jianfeng, > > This patch needs a rebase and some changes as described below. > Would you have time to fix it quickly please?
Thank you for review. Will send out soon. > > > --- a/config/common_base > > +++ b/config/common_base > > @@ -814,3 +814,8 @@ CONFIG_RTE_APP_CRYPTO_PERF=y > > # Compile the eventdev application > > # > > CONFIG_RTE_APP_EVENTDEV=y > > + > > +# > > +# Compile the vdev bus > > +# > > +CONFIG_RTE_LIBRTE_VDEV_BUS=y > > Please move this option in a more logical position. How about moving it after LIBRTE_PCI_BUS? > > > > --- a/lib/librte_eal/linuxapp/eal/Makefile > > +++ b/lib/librte_eal/linuxapp/eal/Makefile > > -LIBABIVER := 6 > > +LIBABIVER := 7 > > No need to bump again the EAL version in 17.11. > > > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) > += -lrte_mempool_ring > > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci > > _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrte_eal > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += -lrte_bus_vdev > > I suggest to move by one line just before -lrte_eal. How about moving it to after rte_bus_pci? Thanks, Jianfeng
