06/11/2017 16:49, Olivier MATZ: > On Mon, Nov 06, 2017 at 02:41:36AM +0100, Thomas Monjalon wrote: > > The functions rte_mempool_populate_phys() and > > rte_mempool_populate_phys_tab() are renamed to > > rte_mempool_populate_iova() and rte_mempool_populate_iova_tab(). > > The deprecated functions are kept as aliases to avoid breaking the API. > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > I agree with the changes of that patch too. > However, after the patches, few references to phys address still > remain in rte_mempool.h. Some examples below: > > /** Mempool over one chunk of physically continuous memory */ > #define MEMPOOL_PG_NUM_DEFAULT 1 > ... > * The memory chunks where objects are stored. Each chunk is virtually > * and physically contiguous. > ... > #define MEMPOOL_F_NO_PHYS_CONTIG 0x0020 /**< Don't need physically contiguous > objs. */ > /** > * This capability flag is advertised by a mempool handler, if the whole > * memory area containing the objects must be physically contiguous. > * Note: This flag should not be passed by application. > */ > #define MEMPOOL_F_CAPA_PHYS_CONTIG 0x0040 > ... > * - Mempool driver must also set MEMPOOL_F_CAPA_PHYS_CONTIG flag along with > * MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS. > ... > * - Otherwise, rte_mempool_populate_phys fails thus pool create fails. > ... > * - MEMPOOL_F_NO_PHYS_CONTIG: If set, allocated objects won't > * necessarily be contiguous in physical memory. > ... > ... > > I think we should also change them to IO.
Yes I did not change them because I was not sure how to word it. Feel free to send a patch for the flags and few other doxygen comments. Thanks
