On 11/1/2017 12:58 PM, Thomas Monjalon wrote: > Hi, there is compilation error with GCC 4.8.5. > It may be a false positive strict aliasing check. > Please could you check it below?
I just get a patch into next-net [1], that should be fixing this build error. [1] http://dpdk.org/browse/next/dpdk-next-net/commit/?id=8bb0ee234e49d1486d4fb63673500c615dbbea1d > > > 25/10/2017 17:07, Akhil Goyal: >> From: Radu Nicolau <radu.nico...@intel.com> >> >> Signed-off-by: Radu Nicolau <radu.nico...@intel.com> >> Signed-off-by: Declan Doherty <declan.dohe...@intel.com> > [...] >> --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c >> +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c >> @@ -123,6 +123,59 @@ ixgbe_rxq_rearm(struct ixgbe_rx_queue *rxq) >> } >> >> static inline void >> +desc_to_olflags_v_ipsec(__m128i descs[4], struct rte_mbuf **rx_pkts) >> +{ >> + __m128i sterr0, sterr1, sterr2, sterr3; >> + __m128i tmp1, tmp2, tmp3, tmp4; >> + __m128i rearm0, rearm1, rearm2, rearm3; >> + >> + const __m128i ipsec_sterr_msk = _mm_set_epi32( >> + 0, IXGBE_RXDADV_IPSEC_STATUS_SECP | >> + IXGBE_RXDADV_IPSEC_ERROR_AUTH_FAILED, >> + 0, 0); >> + const __m128i ipsec_proc_msk = _mm_set_epi32( >> + 0, IXGBE_RXDADV_IPSEC_STATUS_SECP, 0, 0); >> + const __m128i ipsec_err_flag = _mm_set_epi32( >> + 0, PKT_RX_SEC_OFFLOAD_FAILED | PKT_RX_SEC_OFFLOAD, >> + 0, 0); >> + const __m128i ipsec_proc_flag = _mm_set_epi32( >> + 0, PKT_RX_SEC_OFFLOAD, 0, 0); >> + >> + rearm0 = _mm_load_si128((__m128i *)&rx_pkts[0]->rearm_data); >> + rearm1 = _mm_load_si128((__m128i *)&rx_pkts[1]->rearm_data); >> + rearm2 = _mm_load_si128((__m128i *)&rx_pkts[2]->rearm_data); >> + rearm3 = _mm_load_si128((__m128i *)&rx_pkts[3]->rearm_data); >> + sterr0 = _mm_and_si128(descs[0], ipsec_sterr_msk); >> + sterr1 = _mm_and_si128(descs[1], ipsec_sterr_msk); >> + sterr2 = _mm_and_si128(descs[2], ipsec_sterr_msk); >> + sterr3 = _mm_and_si128(descs[3], ipsec_sterr_msk); >> + tmp1 = _mm_cmpeq_epi32(sterr0, ipsec_sterr_msk); >> + tmp2 = _mm_cmpeq_epi32(sterr0, ipsec_proc_msk); >> + tmp3 = _mm_cmpeq_epi32(sterr1, ipsec_sterr_msk); >> + tmp4 = _mm_cmpeq_epi32(sterr1, ipsec_proc_msk); >> + sterr0 = _mm_or_si128(_mm_and_si128(tmp1, ipsec_err_flag), >> + _mm_and_si128(tmp2, ipsec_proc_flag)); >> + sterr1 = _mm_or_si128(_mm_and_si128(tmp3, ipsec_err_flag), >> + _mm_and_si128(tmp4, ipsec_proc_flag)); >> + tmp1 = _mm_cmpeq_epi32(sterr2, ipsec_sterr_msk); >> + tmp2 = _mm_cmpeq_epi32(sterr2, ipsec_proc_msk); >> + tmp3 = _mm_cmpeq_epi32(sterr3, ipsec_sterr_msk); >> + tmp4 = _mm_cmpeq_epi32(sterr3, ipsec_proc_msk); >> + sterr2 = _mm_or_si128(_mm_and_si128(tmp1, ipsec_err_flag), >> + _mm_and_si128(tmp2, ipsec_proc_flag)); >> + sterr3 = _mm_or_si128(_mm_and_si128(tmp3, ipsec_err_flag), >> + _mm_and_si128(tmp4, ipsec_proc_flag)); >> + rearm0 = _mm_or_si128(rearm0, sterr0); >> + rearm1 = _mm_or_si128(rearm1, sterr1); >> + rearm2 = _mm_or_si128(rearm2, sterr2); >> + rearm3 = _mm_or_si128(rearm3, sterr3); >> + _mm_store_si128((__m128i *)&rx_pkts[0]->rearm_data, rearm0); >> + _mm_store_si128((__m128i *)&rx_pkts[1]->rearm_data, rearm1); >> + _mm_store_si128((__m128i *)&rx_pkts[2]->rearm_data, rearm2); >> + _mm_store_si128((__m128i *)&rx_pkts[3]->rearm_data, rearm3); >> +} > > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c: In function desc_to_olflags_v_ipsec: > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:140:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > rearm = _mm_set_epi32(((uint32_t *)rx_pkts[0]->rearm_data)[2], > ^ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:141:10: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > ((uint32_t *)rx_pkts[1]->rearm_data)[2], > ^ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:142:10: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > ((uint32_t *)rx_pkts[2]->rearm_data)[2], > ^ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:143:10: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > ((uint32_t *)rx_pkts[3]->rearm_data)[2]); > ^ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:154:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > ((uint32_t *)rx_pkts[0]->rearm_data)[2] = _mm_extract_epi32(rearm, 3); > ^ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:155:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > ((uint32_t *)rx_pkts[1]->rearm_data)[2] = _mm_extract_epi32(rearm, 2); > ^ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:156:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > ((uint32_t *)rx_pkts[2]->rearm_data)[2] = _mm_extract_epi32(rearm, 1); > ^ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:157:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > ((uint32_t *)rx_pkts[3]->rearm_data)[2] = _mm_extract_epi32(rearm, 0); > ^ >
