> -----Original Message----- > From: Jianbo Liu [mailto:[email protected]] > Sent: Friday, October 27, 2017 3:55 AM > To: [email protected]; Dumitrescu, Cristian <[email protected]> > Cc: Jianbo Liu <[email protected]> > Subject: [PATCH] examples/ip_pipeline: avoid the failure of creating hash > table > > Hash table function will check if the input bucket size is power of 2, > so the parameter should be rounded up before sending to the creating > function. > > Signed-off-by: Jianbo Liu <[email protected]> > --- > examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c | 2 +- > examples/ip_pipeline/pipeline/pipeline_routing_be.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) >
Existing code is simply letting the library detect the misconfiguration and gracefully fail. It avoids duplicating library checks in the app. Your proposal tries to prevent library from failing by silently tweaking some user configuration params. Easier to debug in some cases. For this case, I am OK with your proposal, although not really required, so: Acked-by: Cristian Dumitrescu <[email protected]>
