> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 27, 2017 3:56 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; jblu...@infradead.org; Richardson, Bruce; Ananyev, > Konstantin; De Lara Guarch, Pablo; y...@fridaylinux.org; > maxime.coque...@redhat.com; mtetsu...@gmail.com; Yigit, Ferruh > Subject: Re: [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus > > 27/10/2017 03:06, Jianfeng Tan: > > --- /dev/null > > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > > @@ -0,0 +1,8 @@ > > +DPDK_17.11 { > > + global: > > + > > + rte_vdev_init; > > + rte_vdev_register; > > + rte_vdev_uninit; > > + rte_vdev_unregister; > > +}; > > It should not be needed to export the driver ops.
rte_vdev_register/unregister are needed by vdev PMDs, which are needed to export, isn't it? And for rte_vdev_init()/rte_vdev_uninit(), do you mean we all change to use rte_eal_dev_attach()/detach()? > > Please can you try to make it private? Even we want to make it private, I think it needs deprecation notice, which we can further improved for the next release? Thanks, Jianfeng
