-----Original Message----- > Date: Tue, 17 Oct 2017 16:41:44 +0530 > From: "Rao, Nikhil" <nikhil....@intel.com> > To: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>, > santosh.shu...@caviumnetworks.com, jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org > Subject: Re: [PATCH 2/3] event/octeontx: add support for event Rx adapter > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.4.0 > > On 10/17/2017 2:23 PM, Pavan Nikhilesh wrote: > > Add Rx adapter queue add and delete API for both generic eth_devices as > > well as HW backed eth_octeontx which supports direct event injection to > > event device. > > The HW injected event needs to be converted into mbuf, previously this > > was done in eth_octeontx during rx_burst now it is moved to > > event_octeontx as events from Rx adapter are dequeued directly from > > event device. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > I think the code readability would be better if you compared event_type to > RTE_EVENT_TYPE_ETHDEV. > > Reviewed by: Nikhil Rao <nikhil....@intel.com>
Fixed the missing "-" in Reviewed-by: and applied v4 series to dpdk-next-eventdev/master. Thanks.