> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, October 16, 2017 6:46 PM > To: Wu, Jingjing <jingjing...@intel.com> > Cc: dev@dpdk.org; Tan, Jianfeng <jianfeng....@intel.com>; > shreyansh.j...@nxp.com; > hemant.agra...@nxp.com; santosh.shu...@caviumnetworks.com; Tomasz Duszynski > <t...@semihalf.com>; Jacek Siuda <j...@semihalf.com>; > jerin.ja...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean > > 16/10/2017 12:29, Wu, Jingjing: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Hi, > > > > > > 24/08/2017 04:10, Jingjing Wu: > > > > } else if (intr_handle->type == RTE_INTR_HANDLE_VDEV) { > > > > - /* do nothing, and let vdev driver to initialize this > > > > struct */ > > > > + /* only check, initialization would be done in vdev > > > > driver.*/ > > > > + if (intr_handle->efd_counter_size > > > > > + sizeof(union rte_intr_read_buffer)) { > > > > + RTE_LOG(ERR, EAL, "the efd_counter_size is > oversized"); > > > > + return -EINVAL; > > > > + } > > > > > > How interrupts are working with other buses? > > > > > > Is it something we should manage in bus drivers code? > > > > Any plan to move interrupts from EAL to bus? > > It is an open question :)
OK. How about the patch on current interrupt? I think it is OK, right :)
