On 10/18/2017 2:39 AM, Andrew Rybchenko wrote: > From: Ivan Malov <ivan.ma...@oktetlabs.ru> > > Tx reap mechanism on EF10 native datapath was altered by one > of the recent patches to introduce performance optimisations > using the common technique of freeing mbuf segments in bulks. > > From this perspective, the way of associating SW descriptors > with individual mbuf segments rather than with whole packets > was adopted as a key requirement for the entire optimisation. > > However, only the fast path reap function was amended to fit > the new scheme whilst the corresponding function on the port > stop path was left intact by mistake. This implies incorrect > usage of rte_pktmbuf_free() with regard to separate segments > rather than calling rte_pktmbuf_free_seg() and must be fixed.
Good to know you are OK Ivan, I was worried when previous a few commit logs were not perfectly aligned :) > > Fixes: d321954343c8 ("net/sfc: free mbufs in bulks on EF10 native Tx reap") > > Signed-off-by: Ivan Malov <ivan.ma...@oktetlabs.ru> > Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com> > Reviewed-by: Andy Moreton <amore...@solarflare.com> Applied to dpdk-next-net/master, thanks.