-----Original Message----- From: Thomas Monjalon <tho...@monjalon.net> Date: Tuesday, October 17, 2017 at 1:33 PM To: Ferruh Yigit <ferruh.yi...@intel.com>, Harish Patil <harish.pa...@cavium.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Jianfeng Tan <jianfeng....@intel.com>, Jingjing Wu <jingjing...@intel.com>, "Thotton, Shijith" <shijith.thot...@cavium.com>, Gregory Etelson <greg...@weka.io>, George Prekas <george.pre...@epfl.ch>, "sta...@dpdk.org" <sta...@dpdk.org> Subject: Re: [PATCH] igb_uio: revert open and release operations
>17/10/2017 22:14, Ferruh Yigit: >> There were bug reports about terminated application may leave device in >> undesired state: >> http://dpdk.org/ml/archives/dev/2016-November/049745.html >> http://dpdk.org/ml/archives/dev/2016-November/050932.html >> >> And a proposal to fix: >> http://dpdk.org/ml/archives/dev/2016-December/051844.html >> >> Later another proposal triggered the discussion: >> http://dpdk.org/ml/archives/dev/2017-May/066317.html >> >> Finally a fix patch pushed into v17.08: >> Commit: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of >>device file") >> >> Later a regression report sent related to the pushed patch: >> http://dpdk.org/ml/archives/dev/2017-September/075236.html >> >> And a fix for regression integrated into v17.11-rc1: >> http://dpdk.org/ml/archives/dev/2017-October/079166.html >> Commit: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in >>VM") >> Commit: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17") >> >> Even after the fix qede PMD reported to be broken: >> http://dpdk.org/ml/archives/dev/2017-October/079359.html >> >> So this patch reverts original fix and related commits. The related >> igb_uio code part turns back to v17.05 base. >[...] >> --- >> It would be nice to solve this issue in LTS release, but being close to >> the release and the error report without details makes it hard to work >> more on this issue. > >With this revert, we are back to the original issue. >We must really try the proposed solution. >Harish, please describe your issue and think how it could be fixed. >Jingjing made it work for i40e. >I know it is less effort to request a simple revert. >Please let's try to fix it once for all. Hi Ferruh/Thomas, I’m discussing it internally, so please hold on committing this patch till I revert back to you. Thanks. >
