> -----Original Message----- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, October 17, 2017 10:31 > To: Nipun Gupta <nipun.gu...@nxp.com> > Cc: dev@dpdk.org; Hemant Agrawal <hemant.agra...@nxp.com>; > nikhil....@intel.com > Subject: Re: [PATCH v3 3/4] event/dpaa2: support event eth adapter > > -----Original Message----- > > Date: Tue, 17 Oct 2017 03:14:34 +0530 > > From: Nipun Gupta <nipun.gu...@nxp.com> > > To: dev@dpdk.org > > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > > nikhil....@intel.com, Nipun Gupta <nipun.gu...@nxp.com> > > Subject: [PATCH v3 3/4] event/dpaa2: support event eth adapter > > X-Mailer: git-send-email 1.9.1 > > > > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com> > > Reviewed-by: Nikhil Rao <nikhil....@intel.com> > > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com> > > --- > > Changes in v3: > > Fix shared library build > > Changes in v2: > > Support rx_queue_id = -1 in eth adapter queue and and del (Nikhil) > > Remove duplicate returns (Nikhil) > > > > drivers/Makefile | 2 +- > > drivers/event/Makefile | 4 +- > > drivers/event/dpaa2/Makefile | 2 + > > drivers/event/dpaa2/dpaa2_eventdev.c | 151 > ++++++++++++++++++++++++++++++++++- > > drivers/event/dpaa2/dpaa2_eventdev.h | 8 ++ > > 5 files changed, 163 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 0467250..db0cd76 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -39,6 +39,6 @@ DEPDIRS-net := bus mempool > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto > > DEPDIRS-crypto := bus mempool > > DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event > > -DEPDIRS-event := bus mempool > > +DEPDIRS-event := bus mempool net > > > > include $(RTE_SDK)/mk/rte.subdir.mk > > diff --git a/drivers/event/Makefile b/drivers/event/Makefile > > index d09be74..e119d60 100644 > > --- a/drivers/event/Makefile > > +++ b/drivers/event/Makefile > > @@ -31,7 +31,7 @@ > > > > include $(RTE_SDK)/mk/rte.vars.mk > > > > -core-libs := librte_eal librte_eventdev > > +core-libs := librte_eal librte_ether librte_eventdev > > The above two changes makes sense to me as eventdev-ethdev Rx adapter is > depended on ethdev and there could be an Rx adapter implementation in > event area that may use ethdev driver exported API. > > Can you split driver/event and driver/Makefile change to different > patch?
I have sent the v4 for this series. > > Other than that, This patch set looks good to me and it is ready to merge. > > But, There is a compilation error[1] in event-next tree be case of > Hemant reported problem[2].I can apply this patch set once the solution for > the reported problem[3] is applied to master branch(so that I pull those > changes to next-eventdev to avoid build issue) I understand this :) Thanks, Nipun > > [1] > Applying: event/dpaa2: support event eth adapter > /export/dpdk-next-eventdev/mk/rte.subdir.mk:62: target 'event' given > more than once in the same rule > make[2]: Circular mempool <- event dependency dropped. > > [2] > http://dpdk.org/ml/archives/dev/2017-October/079249.html > > [3] > http://dpdk.org/ml/archives/dev/2017-October/079324.html
