> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Thursday, October 12, 2017 11:49 AM
> To: Dumitrescu, Cristian <cristian.dumitre...@intel.com>; dev@dpdk.org
> Cc: tho...@monjalon.net; adrien.mazarg...@6wind.com; Wu, Jingjing
> <jingjing...@intel.com>; jerin.ja...@caviumnetworks.com; Singh,
> Jasvinder <jasvinder.si...@intel.com>
> Subject: Re: [PATCH V3 3/5] ethdev: add new api for traffic metering and
> policing
>
> On 10/6/2017 8:15 PM, Cristian Dumitrescu wrote:
>
> Overall the patch looks ok. Few small comments.
>
> > diff --git a/lib/librte_ether/rte_mtr.h b/lib/librte_ether/rte_mtr.h
> > new file mode 100644
> > index 0000000..f0f897f
> > --- /dev/null
> > +++ b/lib/librte_ether/rte_mtr.h
> > @@ -0,0 +1,723 @@
> > +/*-
> > + * BSD LICENSE
> > + *
> > + * Copyright(c) 2017 Intel Corporation.
> > + * Copyright(c) 2017 NXP.
>
> can you make it "Copyright 2017 NXP"
> > + * Copyright(c) 2017 Cavium.
> > + * All rights reserved.
> > + *
>
Done as suggested in V4 just sent.
> <snip>...
>
> > +/**
> > + * Statistics counter type
> > + */
> > +enum rte_mtr_stats_type {
> > + /** Number of packets passed as green by the policer. */
> > + RTE_MTR_STATS_N_PKTS_GREEN = 1 << 0,
> > +
> > + /** Number of bytes passed as green by the policer. */
> > + RTE_MTR_STATS_N_BYTES_GREEN = 1 << 1,
> > +
> > + /** Number of packets passed as yellow by the policer. */
> > + RTE_MTR_STATS_N_PKTS_YELLOW = 1 << 2,
> > +
> > + /** Number of bytes passed as yellow by the policer. */
> > + RTE_MTR_STATS_N_BYTES_YELLOW = 1 << 3,
> > +
> > + /** Number of packets passed as red by the policer. */
> > + RTE_MTR_STATS_N_PKTS_RED = 1 << 4,
> > +
> > + /** Number of bytes passed as red by the policer. */
> > + RTE_MTR_STATS_N_BYTES_RED = 1 << 5,
> > +
> > + /** Number of packets dropped by the policer. */
> > + RTE_MTR_STATS_N_PKTS_DROPPED = 1 << 6,
> > +
> > + /** Number of bytes dropped by the policer. */
> > + RTE_MTR_STATS_N_BYTES_DROPPED = 1 << 7,
>
> Trivial one.
> do you want to group the pkts and bytes in separate group respectively?
>
Done as suggested in V4 just sent.
> > +};
> > +
> > +/**
> > + * Statistics counters
> > + */
> > +struct rte_mtr_stats {
> > + /** Number of packets passed by the policer (per color). */
> > + uint64_t n_pkts[RTE_MTR_COLORS];
> > +
> > + /** Number of bytes passed by the policer (per color). */
> > + uint64_t n_bytes[RTE_MTR_COLORS];
> > +
> > + /** Number of packets dropped by the policer. */
> > + uint64_t n_pkts_dropped;
> > +
> > + /** Number of bytes passed by the policer. */
> > + uint64_t n_bytes_dropped;
> > +};
> > +
> > +/**
> > + * Traffic metering algorithms
> > + */
> > +enum rte_mtr_algorithm {
> > + /** Single Rate Three Color Marker (srTCM) - IETF RFC 2697. */
> > + RTE_MTR_SRTCM_RFC2697,
> > +
> > + /** Two Rate Three Color Marker (trTCM) - IETF RFC 2698. */
> > + RTE_MTR_TRTCM_RFC2698,
> > +
> > + /** Two Rate Three Color Marker (trTCM) - IETF RFC 4115. */
> > + RTE_MTR_TRTCM_RFC4115,
>
> I will still prefer if you still add "PASS_THROUGH" as explicit algo.
>
Done as suggested in V4 just sent.
> > +};
> > +
> > +/**
> > + * Meter profile
> > + */
>
