> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Singh, Jasvinder > Sent: Friday, October 6, 2017 4:01 PM > To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org; Yigit, > Ferruh <ferruh.yi...@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com>; Dumitrescu, Cristian > <cristian.dumitre...@intel.com>; adrien.mazarg...@6wind.com > Cc: Iremonger, Bernard <bernard.iremon...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v7 1/4] librte_flow_classify: add > librte_flow_classify library > > ... > > The API in its current form creates the classifier object which will > always use librte_acl based classification mechanism. This behavior > imposes restriction on the application to always pass only ACL table > related parameters for flow classification. In my opinion, API > implementation should be agnostic to specific classification method and > should be generic enough to allow application to select any of the > available flow classification method (for e.g. acl, hash, LPM, etc.). > Otherwise, this library will become another abstraction of librte_acl for > flow classification. > > Also, library allows table entries to be added while creating the > classifier object, not later. Is there any specific reason?
Hi, I think that we should fix this prior to merge. Can we make these changes and target RC2 instead. John
