Hi Jan, > -----Original Message----- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan > Blunck > Sent: Thursday, October 5, 2017 9:14 PM > To: Tan, Jianfeng > Cc: dev; Richardson, Bruce; Ananyev, Konstantin; De Lara Guarch, Pablo; > Thomas Monjalon; y...@fridaylinux.org; Maxime Coquelin; Tetsuya Mukawa; > Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v2 03/12] cryptodev: avoid dependency on > rte_vdev.h > > On Thu, Sep 28, 2017 at 3:55 PM, Jianfeng Tan <jianfeng....@intel.com> > wrote: > > The helper API, rte_cryptodev_vdev_pmd_init(), has a parameter of > > struct rte_vdev_device *, which needs to include rte_vdev.h. > > > > We will move vdev into drivers/bus, so we need to avoid such > > dependency. And also, we cannot break the ABI. > > > > This patch changes that pointer to void *, and defines an internal > > structure same with struct rte_vdev_device. > > > > This code duplication is unnecessary. Also you are doing evil thinks > and define a type with the same name in multiple places. Look at my > series how to do this properly. >
Moving related things into header file is also my plan. Thank for doing that, I'll rebase on your patchset. Thanks, Jianfeng
