This patch is introducing a new abstraction.
It is important to explain it for future readers of this code.

20/09/2017 13:23, Santosh Shukla:
> +/**
> + * IOVA mapping mode.
> + */

Please explain what IOVA means and what is the purpose of
distinguish the different modes.

> +enum rte_iova_mode {
> +     RTE_IOVA_DC = 0,        /* Don't care mode */
> +     RTE_IOVA_PA = (1 << 0),
> +     RTE_IOVA_VA = (1 << 1)
> +};

You should explain each value of the enum.

Reply via email to