On 10/5/2017 10:33 AM, Ophir Munk wrote: > v4 (Ophir): > - Split "net/mlx4: restore Rx scatter support" commit from "net/mlx4: > restore full Rx support bypassing Verbs" commit > > v3 (Adrien): > - Drop a few unrelated or unnecessary changes such as the removal of > MLX4_PMD_TX_MP_CACHE. > - Move device checksum support detection code to its previous location. > - Fix include guard in mlx4_prm.h. > - Reorder #includes alphabetically. > - Replace MLX4_TRANSPOSE() macro with documented inline function. > - Remove extra spaces and blank lines. > - Use uint8_t * instead of char * for buffers. > - Replace mlx4_get_cqe() macro with a documented inline function. > - Replace several unsigned int with uint32_t. > - Add consistency to field names (sge_n => sges_n). > - Make mbuf size checks in RX queue setup function similar to mlx5. > - Update various comments. > - Fix indentation. > - Replace run-time endian conversion with static ones where possible. > - Reorder fields in struct rxq and struct txq for consistency, remove > one level of unnecessary inner structures. > - Fix memory leak on Tx bounce buffer. > - Update commit logs. > - Fix remaining checkpatch warnings. > > v2 (Matan): > Rearange patches. > Semantics. > Enhancements. > Fix compilation issues. > > Moti Haimovsky (6): > net/mlx4: add simple Tx bypassing Verbs > net/mlx4: restore full Rx support bypassing Verbs > net/mlx4: restore Tx gather support > net/mlx4: restore Tx checksum offloads > net/mlx4: restore Rx offloads > net/mlx4: add loopback Tx from VF > > Ophir Munk (1): > net/mlx4: restore Rx scatter support
Hi Ophir, I am a little confused, can you please help me? Currently both mlx4 and mlx5 should support both rdma-core and MLX-OFED, is this correct? When I try to compile these patches with rdma-core, it is giving warning for shared library [1]. If I try to compile with mlx-ofed, getting missing header error [2]. What is the dependency for mlx4 driver now? [1] mlx4_rxq.o: In function `mlx4_rxq_setup': .../dpdk/drivers/net/mlx4/mlx4_rxq.c:393: undefined reference to `mlx4dv_init_obj' mlx4_txq.o: In function `mlx4_txq_setup': .../dpdk/drivers/net/mlx4/mlx4_txq.c:429: undefined reference to `mlx4dv_init_obj' [2] In file included from .../drivers/net/mlx4/mlx4_flow.c:66: .../drivers/net/mlx4/mlx4_rxtx.h:43:10: fatal error: 'infiniband/mlx4dv.h' file not found #include <infiniband/mlx4dv.h> ^~~~~~~~~~~~~~~~~~~~~