> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Thursday, September 28, 2017 11:24 AM > To: dev@dpdk.org > Cc: m...@semihalf.com; d...@marvell.com; nsams...@marvell.com; > jianbo....@linaro.org; Tomasz Duszynski <t...@semihalf.com>; Jacek Siuda > <j...@semihalf.com> > Subject: [dpdk-dev] [PATCH v2 2/4] doc: add mrvl crypto pmd > documentation > > Add documentation for the MRVL CRYPTO PMD driver.
You should add the pmd in the list of device types (devtype), In doc/guides/tools/cryptoperf.rst. Also, you should mention this new PMD in release notes. > > Signed-off-by: Jacek Siuda <j...@semihalf.com> > Signed-off-by: Tomasz Duszynski <j...@semihalf.com> > --- > doc/guides/cryptodevs/features/mrvl.ini | 42 +++++++ > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/cryptodevs/mrvl.rst | 198 ... > +++ b/doc/guides/cryptodevs/mrvl.rst > @@ -0,0 +1,198 @@ ... > + > + ./l2fwd-crypto -c 0x3 --vdev=eth_mrvl,iface=eth0 > + --vdev=cryptodev_mrvl_pmd I will make the comment also in the first patch, but you should use "crypto_mrvl". The cryptodev_*_pmd convention is old and we are only maintaining it for backward compatibility. So, I would use "crypto_mrvl".