> -----Original Message----- > From: Akhil Goyal [mailto:[email protected]] > Sent: Tuesday, October 3, 2017 2:14 PM > To: [email protected] > Cc: Doherty, Declan <[email protected]>; De Lara Guarch, Pablo > <[email protected]>; [email protected]; Nicolau, > Radu <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Mcnamara, John > <[email protected]>; [email protected] > Subject: [PATCH v2 05/12] lib/librte_mbuf: add security crypto flags and > mbuf fields > > From: Boris Pismenny <[email protected]> >
Quick comment about the commit message: 1 - For libraries, there is no need to use "lib/librte...". The convention is to directly use the library name: In this case: "mbuf: add security...". Same applies to patch 4. Also, make sure that the commit message starts with capital letter. Thanks, Pablo > add security crypto flags and update mbuf fields to support IPsec crypto > offload for transmitted packets, and to indicate crypto result for received > packets. >
