> -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, October 3, 2017 2:14 PM > To: dev@dpdk.org > Cc: Doherty, Declan <declan.dohe...@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com>; hemant.agra...@nxp.com; Nicolau, > Radu <radu.nico...@intel.com>; bor...@mellanox.com; > avia...@mellanox.com; tho...@monjalon.net; sandeep.ma...@nxp.com; > jerin.ja...@caviumnetworks.com; Mcnamara, John > <john.mcnam...@intel.com>; olivier.m...@6wind.com > Subject: [PATCH v2 05/12] lib/librte_mbuf: add security crypto flags and > mbuf fields > > From: Boris Pismenny <bor...@mellanox.com> >
Quick comment about the commit message: 1 - For libraries, there is no need to use "lib/librte...". The convention is to directly use the library name: In this case: "mbuf: add security...". Same applies to patch 4. Also, make sure that the commit message starts with capital letter. Thanks, Pablo > add security crypto flags and update mbuf fields to support IPsec crypto > offload for transmitted packets, and to indicate crypto result for received > packets. >
