> -----Original Message----- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, October 2, 2017 1:24 AM > To: Li, Xiaoyun <xiaoyun...@intel.com> > Cc: Wu, Jingjing <jingjing...@intel.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when > start app > > On Sat, 30 Sep 2017 09:59:08 +0800 > Xiaoyun Li <xiaoyun...@intel.com> wrote: > > > To make the performance can be tuning on different NICs or platforms. We > > need to make the number of descriptors and Rx/TX threshold as arguments > > when starting l3fwd application. > > > > Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com> > > Not sure about this. The point of l3fwd is to make it as simple > an application as possible to help users. > > Given that drivers can now supply default values for thresholds, I think > the l3fwd sample should get rid of all the special descriptor values it > is setting. Then if the values are not right for best performance that should > be pushed back to the driver writer to fix.
But now what the driver using are the arguments passed from l3fwd application, such as RTE_TEST_RX_DESC_DEFAULT. About the threshold, I guess it is already done by driver to use default value. For number of descriptors, any ideas? Diver to provide a suggestion one?
