>-----Original Message----- >From: Ananyev, Konstantin >Sent: Wednesday, October 4, 2017 5:27 PM >To: Kavanagh, Mark B <mark.b.kavan...@intel.com>; dev@dpdk.org >Cc: Hu, Jiayu <jiayu...@intel.com>; Tan, Jianfeng <jianfeng....@intel.com>; >Yigit, Ferruh <ferruh.yi...@intel.com>; tho...@monjalon.net >Subject: RE: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO > > > >> -----Original Message----- >> From: Kavanagh, Mark B >> Sent: Wednesday, October 4, 2017 5:23 PM >> To: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org >> Cc: Hu, Jiayu <jiayu...@intel.com>; Tan, Jianfeng <jianfeng....@intel.com>; >Yigit, Ferruh <ferruh.yi...@intel.com>; tho...@monjalon.net >> Subject: RE: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO >> >> >> >> >-----Original Message----- >> >From: Ananyev, Konstantin >> >Sent: Wednesday, October 4, 2017 4:09 PM >> >To: Kavanagh, Mark B <mark.b.kavan...@intel.com>; dev@dpdk.org >> >Cc: Hu, Jiayu <jiayu...@intel.com>; Tan, Jianfeng <jianfeng....@intel.com>; >> >Yigit, Ferruh <ferruh.yi...@intel.com>; tho...@monjalon.net >> >Subject: RE: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO >> > >> > >> > >> >> -----Original Message----- >> >> From: Kavanagh, Mark B >> >> Sent: Monday, October 2, 2017 5:46 PM >> >> To: dev@dpdk.org >> >> Cc: Hu, Jiayu <jiayu...@intel.com>; Tan, Jianfeng ><jianfeng....@intel.com>; >> >Ananyev, Konstantin <konstantin.anan...@intel.com>; Yigit, >> >> Ferruh <ferruh.yi...@intel.com>; tho...@monjalon.net; Kavanagh, Mark B >> ><mark.b.kavan...@intel.com> >> >> Subject: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO >> >> >> >> From: Jiayu Hu <jiayu...@intel.com> >> >> >> >> This patch adds GSO support to the csum forwarding engine. Oversized >> >> packets transmitted over a GSO-enabled port will undergo segmentation >> >> (with the exception of packet-types unsupported by the GSO library). >> >> GSO support is disabled by default. >> >> >> >> GSO support may be toggled on a per-port basis, using the command: >> >> >> >> "set port <port_id> gso on|off" >> >> >> >> The maximum packet length (including the packet header and payload) for >> >> GSO segments may be set with the command: >> >> >> >> "set gso segsz <length>" >> >> >> >> Show GSO configuration for a given port with the command: >> >> >> >> "show port <port_id> gso" >> >> >> >> Signed-off-by: Jiayu Hu <jiayu...@intel.com> >> >> Signed-off-by: Mark Kavanagh <mark.b.kavan...@intel.com> >> >> --- >> >> app/test-pmd/cmdline.c | 178 >> >++++++++++++++++++++++++++++ >> >> app/test-pmd/config.c | 24 ++++ >> >> app/test-pmd/csumonly.c | 69 ++++++++++- >> >> app/test-pmd/testpmd.c | 13 ++ >> >> app/test-pmd/testpmd.h | 10 ++ >> >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 46 +++++++ >> >> 6 files changed, 335 insertions(+), 5 deletions(-) >> >> >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> >> index ccdf239..05b0ce8 100644 >> >> --- a/app/test-pmd/cmdline.c >> >> +++ b/app/test-pmd/cmdline.c >> >> @@ -431,6 +431,17 @@ static void cmd_help_long_parsed(void >*parsed_result, >> >> " Set max flow number and max packet number per-flow" >> >> " for GRO.\n\n" >> >> >> >> + "set port (port_id) gso (on|off)" >> >> + " Enable or disable Generic Segmentation Offload in" >> >> + " csum forwarding engine.\n\n" >> >> + >> >> + "set gso segsz (length)\n" >> >> + " Set max packet length for output GSO segments," >> >> + " including packet header and payload.\n\n" >> > >> >Probably a good future improvement would be to allow user to specify >gso_type >> >too. >> >> Would you like to see that change implemented in time for the 17.11 release? > >I think that's too late for such change in 17.11. >My thought was about 18.02 here. >Konstantin
No problem - thanks Konstantin.
