Hi Thomas
On 2/10/2017 3:55 PM, Thomas Monjalon wrote:
Hi,
I have some comments about the API scope and some formatting.
Suggested title:
power: add turbo functions to map file
02/10/2017 14:20, David Hunt:
allows vm_power_manager example to be built against shared libraries
Fixes: 94608a0f7f45 ("power: add per-core turbo boost API")
Sure, I'll address this in next version.
Signed-off-by: David Hunt <david.h...@intel.com>
[...]
+DPDK_17.11 {
+ global:
+
+ rte_power_acpi_turbo_status;
Is it really the function you want to expose?
rte_power_turbo_status seems more generic.
Not really, it was in there for completeness, but users should be able
to keep track of the turbo'd cores, so not really needed.
More comments about what is part of the API:
If you do not want to expose ACPI and VM implementations,
it should not be part of the rte_* include files.
+ rte_power_freq_disable_turbo;
+ rte_power_freq_enable_turbo;
+};
+
This is a trailing new line.
I'll address the above comments in the next version.
Regards,
Dave.
