> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kuba Kozak > Sent: Friday, September 22, 2017 2:18 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Kozak, KubaX <kubax.ko...@intel.com>; > jan.wick...@ericsson.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] vhost: fix unchecked return value > > Add return value check for poll() call. > > Coverity issue: 140740 > Fixes: 59317cef249c ("vhost: allow many vhost-user ports") > Cc: jan.wick...@ericsson.com > Cc: sta...@dpdk.org > > Signed-off-by: Kuba Kozak <kubax.ko...@intel.com> > --- > lib/librte_vhost/fd_man.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c > index 2ceacc9..4c6fed4 100644 > --- a/lib/librte_vhost/fd_man.c > +++ b/lib/librte_vhost/fd_man.c > @@ -222,6 +222,7 @@ fdset_event_dispatch(void *arg) > int remove1, remove2; > int need_shrink; > struct fdset *pfdset = arg; > + int val; > > if (pfdset == NULL) > return NULL; > @@ -239,7 +240,9 @@ fdset_event_dispatch(void *arg) > numfds = pfdset->num; > pthread_mutex_unlock(&pfdset->fd_mutex); > > - poll(pfdset->rwfds, numfds, 1000 /* millisecs */); > + val = poll(pfdset->rwfds, numfds, 1000 /* millisecs */); > + if (val < 0) > + continue; > > need_shrink = 0; > for (i = 0; i < numfds; i++) { > -- > 2.7.4
Hi Yu / Maxime, I would like to ask for a feedback regarding proposed fix. If everything is ok with it, please send acked-by. Best regards Michal.
