-----Original Message----- > Date: Sun, 24 Sep 2017 23:54:38 +0530 > From: "Rao, Nikhil" <nikhil....@intel.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com> > CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, > tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com, > nipun.gu...@nxp.com, narender.vang...@intel.com, > erik.g.carri...@intel.com, abhinandan.guj...@intel.com, > santosh.shu...@caviumnetworks.com > Subject: Re: [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter > APIs > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.3.0 > > On 9/22/2017 5:42 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Fri, 22 Sep 2017 02:47:14 +0530 > > > From: Nikhil Rao <nikhil....@intel.com> > > > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > > > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > > > harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > > > narender.vang...@intel.com, erik.g.carri...@intel.com, > > > abhinandan.guj...@intel.com, santosh.shu...@caviumnetworks.com > > > Subject: [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs > > > X-Mailer: git-send-email 2.7.4 > > > > > > Add unit tests for rte_event_eth_rx_adapter_xxx() APIs > > > <snip> > > > > +#include <string.h> > > > +#include <rte_common.h> > > > +#include <rte_mempool.h> > > > +#include <rte_mbuf.h> > > > +#include <rte_ethdev.h> > > > +#include <rte_eventdev.h> > > > + > > > +#include <rte_event_eth_rx_adapter.h> > > > + > > > +#include "test.h" > > > + > > > +/* i40e limits max to 64 */ > > > > This comment could be removed. > > > OK, I am documenting why the code doesn't just use dev_info.max_rx_queues, > won't the comment be useful to retain ?
OK. If dev_info.max_rx_queues for i40e is not 64 as expected then we could the fix the i40e driver as well. >
