Hi, > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Vladimir > Medvedkin > Sent: Tuesday, August 22, 2017 4:57 PM > To: Yangchao Zhou <zhouya...@gmail.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] hash: optimize the softrss computation > > Hi, > > 2017-08-22 15:02 GMT+03:00 Yangchao Zhou <zhouya...@gmail.com>: > > > Use rte_bsf32 and fast bit unset operation to optimize the softrss > > computation. > > The following measurements shows improvement over the default softrss > > computation function. > > > > tuple lens old(cycles) new(cycles) > > 3 1225 337 > > 9 3743 992 > > > > Signed-off-by: Yangchao Zhou <zhouya...@gmail.com>
Commit message is a bit long. Could you wrap it to have less than 75 characters per line? Although, the patch itself has lines with more than 90 characters, which should be avoided: http://dpdk.org/ml/archives/test-report/2017-August/027283.html Last thing, the "Reviewed-by" has an extra space, before the name. Thanks, Pablo > > > Looks good for me. Thanks! > > Reviewed-by: Medvedkin Vladimir <medvedk...@gmail.com> > > -- > Regards, > Vladimir
