On Thu, Sep 21, 2017 at 10:25:18AM +0000, Dumitrescu, Cristian wrote: Hi Cristian, > Hi Pavan, > > Thank you, just a couple of minor issues below: > Sure will spin up a v3 with the mentioned changes.
Thanks, Pavan > > -----Original Message----- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Wednesday, September 20, 2017 4:37 PM > > To: Dumitrescu, Cristian <cristian.dumitre...@intel.com>; > > step...@networkplumber.org > > Cc: dev@dpdk.org; Pavan Bhagavatula > > <pbhagavat...@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched > > > > From: Pavan Bhagavatula <pbhagavat...@caviumnetworks.com> > > > > The librte_sched uses rte_bitmap to manage large arrays of bits in an > > optimized method so, moving it to eal/common would allow other libraries > > and applications to use it. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > --- > > > > v2 changes: > > - undo rte_bitmap.h cosmetic changes > > - update maintainer info > > > > lib/librte_eal/common/Makefile | 1 + > > lib/{librte_sched => librte_eal/common/include}/rte_bitmap.h | 0 > > lib/librte_sched/Makefile | 5 +++-- > > lib/librte_sched/rte_sched.c | 2 +- > > 4 files changed, 5 insertions(+), 3 deletions(-) > > rename lib/{librte_sched => librte_eal/common/include}/rte_bitmap.h > > (100%) > > > > diff --git a/lib/librte_eal/common/Makefile > > b/lib/librte_eal/common/Makefile > > index e8fd67a..c2c6a7f 100644 > > --- a/lib/librte_eal/common/Makefile > > +++ b/lib/librte_eal/common/Makefile > > @@ -42,6 +42,7 @@ INC += rte_hexdump.h rte_devargs.h rte_bus.h > > rte_dev.h rte_vdev.h > > INC += rte_pci_dev_feature_defs.h rte_pci_dev_features.h > > INC += rte_malloc.h rte_keepalive.h rte_time.h > > INC += rte_service.h rte_service_component.h > > +INC += rte_bitmap.h > > > > GENERIC_INC := rte_atomic.h rte_byteorder.h rte_cycles.h rte_prefetch.h > > GENERIC_INC += rte_spinlock.h rte_memcpy.h rte_cpuflags.h rte_rwlock.h > > diff --git a/lib/librte_sched/rte_bitmap.h > > b/lib/librte_eal/common/include/rte_bitmap.h > > similarity index 100% > > rename from lib/librte_sched/rte_bitmap.h > > rename to lib/librte_eal/common/include/rte_bitmap.h > > diff --git a/lib/librte_sched/Makefile b/lib/librte_sched/Makefile > > index 18274e7..9a28a9e 100644 > > --- a/lib/librte_sched/Makefile > > +++ b/lib/librte_sched/Makefile > > @@ -55,7 +55,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_SCHED) += rte_sched.c > > rte_red.c rte_approx.c > > SRCS-$(CONFIG_RTE_LIBRTE_SCHED) += rte_reciprocal.c > > > > # install includes > > -SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include := rte_sched.h > > rte_bitmap.h rte_sched_common.h rte_red.h rte_approx.h > > -SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_reciprocal.h > > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include := rte_sched.h > > rte_sched_common.h > > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_reciprocal.h > > rte_red.h > > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_approx.h > > > > These changes are not required, please just remove the rte_bitmap.h from this > list with no other changes. > > > include $(RTE_SDK)/mk/rte.lib.mk > > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > > index b7cba11..b3e0d4f 100644 > > --- a/lib/librte_sched/rte_sched.c > > +++ b/lib/librte_sched/rte_sched.c > > @@ -34,6 +34,7 @@ > > #include <stdio.h> > > #include <string.h> > > > > +#include <rte_bitmap.h> > > Please #include <rte_bitmap.h> at the end of the #include <rte_*.h> list. > > > #include <rte_common.h> > > #include <rte_log.h> > > #include <rte_memory.h> > > @@ -44,7 +45,6 @@ > > #include <rte_mbuf.h> > > > > #include "rte_sched.h" > > -#include "rte_bitmap.h" > > #include "rte_sched_common.h" > > #include "rte_approx.h" > > #include "rte_reciprocal.h" > > -- > > 2.7.4 > > Regards, > Cristian >
