> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Boris Pismenny > Sent: Sunday, September 17, 2017 1:07 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan <declan.dohe...@intel.com>; De > Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; > hemant.agra...@nxp.com; Nicolau, Radu <radu.nico...@intel.com>; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > sandeep.ma...@nxp.com; jerin.ja...@caviumnetworks.com; > nelio.laranje...@6wind.com; lir...@mellanox.com > Subject: [dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security > actions > > Signed-off-by: Boris Pismenny <bor...@mellanox.com>
Thanks for the docs. Minor comments below. > + > +Multiple flows can be configured to use the same security session. > + > +- Non-terminating by default. This is a single bullet point list and it seems disconnected from the previous line. Maybe convert it to a sentence instead. > + > +.. _table_rte_flow_action_security This is missing a colon at the end and causes a doc build warning. > +Usage example, configure IPsec inline using INLINE_CRYPTO security > session: This doesn't seem to connect to the following paragraph. Maybe something like: The following is an example of configuring IPsec inline using the INLINE_CRYPTO security session: Reviewed-by: John McNamara <john.mcnam...@intel.com>