-----Original Message----- > Date: Thu, 14 Sep 2017 17:08:59 +0100 > From: Harry van Haaren <harry.van.haa...@intel.com> > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > <harry.van.haa...@intel.com> > Subject: [PATCH v4 0/4] eventdev: add attribute based get APIs > X-Mailer: git-send-email 2.7.4 > > This patchset refactors the eventdev API to be more flexible > and capable. In particular, the API is capable of returning an > error value if an invalid device, port or attribute ID is passed > in, which was not possible with the previous APIs. > > The implementation of this patchset is based on a v1 patch[1], > and after some discussion this API was seen as the best solution. > > In terms of flexibility, the attribute id allows addition of new > common eventdev layer attributes without breaking ABI or adding > new functions. Note that these attributes are not data-path, and > that PMDs should continue to use the xstats API for reporting any > unique PMD statistics that are available. > > Regarding API/ABI compatibility, I have removed the functions from > the .map files - please review the .map file changes for ABI issues > carefully. > > The last patch of this series adds a started attribute to the device, > allowing the application to query if a device is currently running. > > -Harry > > [1] http://dpdk.org/dev/patchwork/patch/27152/ > > --- > > v4: > - Rework based on review by Jerin > - default: cases into switches > - Remove old functions from .map file > - Remove /* out */ parameters > - Rework header file definitions to match logical order > - Rework patch split > - Cleaner removal of queue_count() function
The changes looks good. Since the functions are removed, we need to update .so version. Please update LIBABIVER(file: lib/librte_eventdev/Makefile) and update the release notes reference to the similar change: http://dpdk.org/browse/dpdk/commit/?id=945081a76ab0bb481f1d62125aa5b547fcc000bd
