On 9/14/2017 10:48 AM, Kumar, Ravi1 wrote: >> On 9/13/2017 6:47 PM, Ravi Kumar wrote: >>> Signed-off-by: Ravi Kumar <ravi1.ku...@amd.com> >>> --- >>> config/common_base | 6 ++++++ >>> mk/rte.app.mk | 1 + >>> 2 files changed, 7 insertions(+) >>> >>> diff --git a/config/common_base b/config/common_base index >>> 5e97a08..fab46b5 100644 >>> --- a/config/common_base >>> +++ b/config/common_base >>> @@ -405,6 +405,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y >>> CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n >>> >>> # >>> +# Compile AMD PMD >>> +# >>> +CONFIG_RTE_LIBRTE_AXGBE_PMD=n >> >> Hi Ravi, >> >> This is a new networking driver from AMD. Great to see new vendors in DPDK, >> welcome. >> >> Patch 2/4 seems missing in the mail list, it may be stuck because of the >> size limit if it is a big patch, which may mean it needs to be split into >> multiple patches :) >> >> Thanks, >> ferruh > > Hi Ferruh, > > Thanks a lot. The Patch 2/4 got posted just now. It will be great to get > review comments on the same.
At first glance: - There is a new licensing, that needs to be approved. - patch 2/4 is big and hard to review properly, is it possible to have multiple incremental patches, there are good previous samples of this. - Can you please update release notes to announce new PMD? - ICC is giving build error [1], but this can be handled later. [1] #pragma GCC diagnostic ignored "-Wcast-qual" > > Regards, > Ravi <...>
