> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, September 11, 2017 6:53 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 4/4] eventdev: add device started attribute > > -----Original Message----- > > Date: Fri, 8 Sep 2017 16:36:55 +0100 > > From: Harry van Haaren <harry.van.haa...@intel.com> > > To: dev@dpdk.org > > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > > <harry.van.haa...@intel.com> > > Subject: [PATCH v3 4/4] eventdev: add device started attribute > > X-Mailer: git-send-email 2.7.4 > > > > This commit adds an attribute to the eventdev, allowing applications > > to retrieve if the eventdev is running or stopped. Note that no API > > or ABI changes were required in adding the statistic, and code changes > > are minimal. > > > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > --- > > lib/librte_eventdev/rte_eventdev.c | 3 +++ > > lib/librte_eventdev/rte_eventdev.h | 4 ++++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/lib/librte_eventdev/rte_eventdev.c > b/lib/librte_eventdev/rte_eventdev.c > > index 3756ec7..87a1e19 100644 > > --- a/lib/librte_eventdev/rte_eventdev.c > > +++ b/lib/librte_eventdev/rte_eventdev.c > > @@ -740,6 +740,9 @@ rte_event_dev_attr_get(uint8_t dev_id, uint32_t attr_id, > > I think, the new rte_event_dev_attr_get function, we can move up so that > all device specific functions comes back to back in API documentation. > > Check the output of "make doc-api-html" > > Other than that, it looks good. > > Acked-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>
Thanks for the review - all comments make sense. Will respin with comments addressed, and include Acks.
