Hi Pablo,
On 9/8/2017 7:33 PM, De Lara Guarch, Pablo wrote:
Hi Akhil,
-----Original Message-----
From: Akhil Goyal [mailto:akhil.go...@nxp.com]
Sent: Tuesday, August 29, 2017 7:59 AM
To: dev@dpdk.org; De Lara Guarch, Pablo
<pablo.de.lara.gua...@intel.com>
Cc: hemant.agra...@nxp.com; Doherty, Declan
<declan.dohe...@intel.com>; Akhil Goyal <akhil.go...@nxp.com>
Subject: [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs
in case of HMAC the openssl APIs HMAC_XXX give better performance for
all HMAC cases as compared with EVP_XXX
Signed-off-by: Akhil Goyal <akhil.go...@nxp.com>
---
changes in v2:
patch split in two patches as per Pablo's recommendations
drivers/crypto/openssl/rte_openssl_pmd.c | 37 +++++++++++++-------
I just come across an issue with this patch on openssl 1.1.0 (below).
Unfortunately, I have already applied the patch in the subtree, but if you
could send a patch to fix this,
I can integrate as part of that patch.
Thanks,
Pablo
drivers/crypto/openssl/rte_openssl_pmd_private.h:168:14: error: field 'ctx' has
incomplete type
HMAC_CTX ctx;
^~~
In file included from drivers/crypto/openssl/rte_openssl_pmd_ops.c:39:0:
drivers/crypto/openssl/rte_openssl_pmd_private.h:168:14: error: field 'ctx' has
incomplete type
HMAC_CTX ctx;
^~~
drivers/crypto/openssl/rte_openssl_pmd.c: In function
'openssl_set_session_auth_parameters':
drivers/crypto/openssl/rte_openssl_pmd.c:440:3: error: implicit declaration of
function 'HMAC_CTX_init'; did you mean 'HMAC_CTX_new'?
[-Werror=implicit-function-declaration]
HMAC_CTX_init(&sess->auth.hmac.ctx);
^~~~~~~~~~~~~
HMAC_CTX_new
drivers/crypto/openssl/rte_openssl_pmd.c:440:3: error: nested extern
declaration of 'HMAC_CTX_init' [-Werror=nested-externs]
make[4]: *** [mk/internal/rte.compile-pre.mk:140: rte_openssl_pmd_ops.o] Error 1
make[4]: *** Waiting for unfinished jobs....
drivers/crypto/openssl/rte_openssl_pmd.c: In function 'openssl_reset_session':
drivers/crypto/openssl/rte_openssl_pmd.c:588:3: error: implicit declaration of
function 'HMAC_CTX_cleanup'; did you mean 'HMAC_CTX_get_md'?
[-Werror=implicit-function-declaration]
HMAC_CTX_cleanup(&sess->auth.hmac.ctx);
^~~~~~~~~~~~~~~~
HMAC_CTX_get_md
drivers/crypto/openssl/rte_openssl_pmd.c:588:3: error: nested extern
declaration of 'HMAC_CTX_cleanup' [-Werror=nested-externs]
cc1: all warnings being treated as errors
make[4]: *** [mk/internal/rte.compile-pre.mk:140: rte_openssl_pmd.o] Error 1
I will look into this and will send the patch ASAP.
Regards,
Akhil
