> -----Original Message----- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, September 6, 2017 4:37 PM > To: Pavan Nikhilesh Bhagavatula <pbhagavat...@caviumnetworks.com> > Cc: Kevin Traynor <ktray...@redhat.com>; Dumitrescu, Cristian > <cristian.dumitre...@intel.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal > > On Wed, 6 Sep 2017 20:11:34 +0530 > Pavan Nikhilesh Bhagavatula <pbhagavat...@caviumnetworks.com> wrote: > > > On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: > > > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > > > > From: Pavan Bhagavatula <pbhagavat...@caviumnetworks.com> > > > > > > > > Currently, rte_reciprocal only supports unsigned 32bit divisors. This > > > > commit adds support for unsigned 64bit divisors. > > > > > > > > Rename unsigned 32bit specific functions appropriately and update > > > > librte_sched accordingly. > > > > > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > > > --- > > > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 +- > > > > lib/librte_eal/common/include/rte_reciprocal.h | 109 > ++++++++++++++++++++-- > > > > lib/librte_eal/common/rte_reciprocal.c | 116 > +++++++++++++++++++++--- > > > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 3 +- > > > > lib/librte_sched/Makefile | 4 +- > > > > lib/librte_sched/rte_sched.c | 9 +- > > > > 6 files changed, 219 insertions(+), 25 deletions(-) > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > > index 90d7258..59a85bb 100644 > > > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > > @@ -241,6 +241,7 @@ EXPERIMENTAL { > > > > DPDK_17.11 { > > > > global: > > > > > > > > - rte_reciprocal_value; > > > > + rte_reciprocal_value_u32; > > > > + rte_reciprocal_value_u64; > > > > > > > > } DPDK_17.08; > > > > diff --git a/lib/librte_eal/common/include/rte_reciprocal.h > b/lib/librte_eal/common/include/rte_reciprocal.h > > > > index b6d752f..85599e6 100644 > > > > --- a/lib/librte_eal/common/include/rte_reciprocal.h > > > > +++ b/lib/librte_eal/common/include/rte_reciprocal.h > > > > > > Hi Pavan, sorry for commenting late but the license in v1 of this file > > > states it cannot be removed. It is not included in later versions - can > > > you explain why? > > > > > Hi Kevin, > > > > I have misinterpreted this mail > > http://dpdk.org/ml/archives/dev/2017-August/073781.html, > > any suggestion on how to proceed on this further? > > > > Thanks, > > Pavan > > License issues need legal advice (TAB could ask LF if required). > Sorry, I am a cynic engineer not a lawyer. > > Easiest solution is to find equivalent code in FreeBSD or some other project > which does not have the restrictions.
How about just adding your copyright on the existing BSD license?
