> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, September 5, 2017 3:31 PM > To: Tan, Jianfeng > Cc: Richardson, Bruce; dev@dpdk.org; xen-de...@lists.xenproject.org; > Mcnamara, John; joao.m.mart...@oracle.com; > jerin.ja...@caviumnetworks.com; shah...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support > > 05/09/2017 05:41, Tan, Jianfeng: > > From: Richardson, Bruce > > > > > > Reading the contributors guide section on ABI, specifically > > > http://dpdk.org/doc/guides/contributing/versioning.html#deprecating- > an- > > > entire-abi-version > > > it seems like we should collapse down the versions to a single one > > > following the function removal, and also increment the whole library so > > > version. > > > > So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change > it in below way? > > > > DPDK_2.1 { > > {APIs in DPDK_2.0 except xen APIs} > > ... > > }; > > > > DPDK_16.04 { > > {APIs in DPDK_2.1 except xen APIs} > > ... > > } DPDK_2.1; > > No, you don't need to collapse. You can just remove Xen functions.
Thanks. Besides, two more things: 1. Shall we increase the so version? 2. This patch is about 8K lines long, do we need to split?
