> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, September 1, 2017 11:04 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richard...@intel.com>
> Subject: [dpdk-dev] [PATCH 05/17] build: add buildtools to meson build
>
> Add the buildtools folder, and more specifically the pmdinfogen binary to
> the meson and ninja build. This will be needed for building the PMDs in the
> driver folder later, as the pmd info output from the tool needs to be
> included in those libs.
>
> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
<snip>
> +error_cflags = ['-Wno-maybe-uninitialized']
> +cflags = []
> +foreach arg: error_cflags
> + if cc.has_argument(arg)
> + cflags += arg
> + endif
> +endforeach
Removing the '-Wno-maybe-uninitialized' still compiles fine here with Clang.
GCC prints a warning... this could probably be fixed in "pmdinfogen.c" in
future,
but this should not be done in the build-next branch, but patched in mainline
and
then updated in the meson build.
> +
> +pmdinfogen = executable('pmdinfogen',
> + 'pmdinfogen.c',
> + include_directories: eal_inc,
> + c_args: cflags)
> diff --git a/meson.build b/meson.build
> index f0e5741e3..d95321022 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -59,6 +59,7 @@ subdir('config')
>
> # build libs and (TODO) drivers
> subdir('lib')
> +subdir('buildtools')
>
> # TODO build binaries and installable tools
>
> --
> 2.13.5
Reviewed-by: Harry van Haaren <harry.van.haa...@intel.com>
