> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com]
> Sent: Tuesday, August 29, 2017 12:00 PM
> To: Van Haaren, Harry <harry.van.haa...@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v3] service: add API for service count per lcore
>
> This new API returns the number of services that are running on a specific
> service core. It allows an application to decide which service core to run
> a new service on.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
> ---
>
> v3 changes:
> - fix compilation issues with .map files
>
> v2 changes:
> - reword the commit title according to the check-git-log.sh
> - modify return types
> - add function to .map file
>
> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
> lib/librte_eal/common/include/rte_service.h | 13 +++++++++++++
> lib/librte_eal/common/rte_service.c | 13 +++++++++++++
> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
> 4 files changed, 28 insertions(+)
>
> diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> index aac6fd7..79e7d31 100644
> --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> @@ -222,6 +222,7 @@ EXPERIMENTAL {
> rte_service_is_running;
> rte_service_lcore_add;
> rte_service_lcore_count;
> + rte_service_lcore_count_services;
> rte_service_lcore_del;
> rte_service_lcore_list;
> rte_service_lcore_reset_all;
> diff --git a/lib/librte_eal/common/include/rte_service.h
> b/lib/librte_eal/common/include/rte_service.h
> index 7c6f738..9537ae5 100644
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
> @@ -374,6 +374,19 @@ int32_t rte_service_lcore_list(uint32_t array[],
> uint32_t n);
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice
> *
> + * Get the numer of services running on the supplied lcore.
> + *
> + * @param Lcore Id of the service core.
> + * @retval >=0 Number of services registered to this core.
> + * @retval -EINVAL Invalid lcore provided
> + * @retval -ENOTSUP The provided lcore is not a service core.
> + */
> +int32_t rte_service_lcore_count_services(uint32_t lcore);
Building the documentation[1] fails, the @param Lcore should have be @param
lcore (note the non-capital L, to keep doxygen happy).
Sorry for missing that last review.
With that fix;
Acked-by: Harry van Haaren <harry.van.haa...@intel.com>
[1] I tested using this command: ./devtools/test-build.sh
x86_64-native-linuxapp-clang+shared+next+debug
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Dumps any information available about the service. If service is NULL,
> * dumps info for all services.
> */
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 7efb76d..616bad3 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -397,6 +397,19 @@ rte_service_lcore_list(uint32_t array[], uint32_t n)
> }
>
> int32_t
> +rte_service_lcore_count_services(uint32_t lcore)
> +{
> + if (lcore >= RTE_MAX_LCORE)
> + return -EINVAL;
> +
> + struct core_state *cs = &lcore_states[lcore];
> + if (!cs->is_service_core)
> + return -ENOTSUP;
> +
> + return __builtin_popcountll(cs->service_mask);
> +}
> +
> +int32_t
> rte_service_start_with_defaults(void)
> {
> /* create a default mapping from cores to services, then start the
> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> index 3a8f154..468c706 100644
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -227,6 +227,7 @@ EXPERIMENTAL {
> rte_service_is_running;
> rte_service_lcore_add;
> rte_service_lcore_count;
> + rte_service_lcore_count_services;
> rte_service_lcore_del;
> rte_service_lcore_list;
> rte_service_lcore_reset_all;
> --
> 2.7.4
