On Fri, Aug 25, 2017 at 12:55:21AM +0000, David Harton (dharton) wrote: > > > > -----Original Message----- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Thursday, August 24, 2017 7:37 PM > > To: David Harton (dharton) <dhar...@cisco.com> > > Cc: tho...@monjalon.net; ferruh.yi...@intel.com; > > stephen.h...@broadcom.com; ajit.khapa...@broadcom.com; John Daley > > (johndale) <johnd...@cisco.com>; wenzhuo...@intel.com; > > konstantin.anan...@intel.com; jingjing...@intel.com; > > beilei.x...@intel.com; jing.d.c...@intel.com; adrien.mazarg...@6wind.com; > > nelio.laranje...@6wind.com; alejandro.luc...@netronome.com; > > hemant.agra...@nxp.com; rasesh.m...@cavium.com; harish.pa...@cavium.com; > > skh...@vmware.com; y...@fridaylinux.org; maxime.coque...@redhat.com; > > allain.leg...@windriver.com; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to > > return int > > > > On Thu, 24 Aug 2017 19:18:51 -0400 > > David Harton <dhar...@cisco.com> wrote: > > > > > @@ -2031,7 +2031,7 @@ struct avp_queue { > > > mask = (ETH_VLAN_STRIP_MASK | > > > ETH_VLAN_FILTER_MASK | > > > ETH_VLAN_EXTEND_MASK); > > > - avp_vlan_offload_set(eth_dev, mask); > > > + (void)avp_vlan_offload_set(eth_dev, mask); > > > > This is a BSDism. You don't need the void cast. > > Never know what to do...SA tools and some compilers whine if I don't. > People complain if I do. :) > > What if I check the return code and log an error?
Sounds like a case of "doing the right thing" to me :-)
