07/08/2017 15:17, Wiles, Keith: > > > On Aug 7, 2017, at 6:35 AM, Thomas Monjalon <tho...@monjalon.net> wrote: > > > > Hi, > > > > 06/07/2017 16:56, Keith Wiles: > >> +# Locate the rte_version.h file and parse out the version strings. > > > > I think this script is not needed because we have already > > something in mk/rte.sdkconfig.mk. > > Example: > > % make showversion > > 17.08.0-rc4 > > Executing make to find out a version seems to bit of over kill to me and a > simple script would be much easier IMO. I do not really see harm in having > this script that can output the version into different formats is helpful > when running external scripts. Also in the future we are most like going to > replace the build system and then we would need to add this support to that > build system and having it in a standalone script is easier manage in the > long run.
"make showversion" is here for several years. Usually we do not implement the same thing in several places without a good reason. And some users can use the old command. Especially when talking about versions, it is very convenient to use the same command in every versions. That's why I insist: why implementing it differently? If it is only about the new build system, it should be part of the build system migration plan (long term).
