> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, August 4, 2017 11:21 AM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eventdev: fix missing includes > > The PCI helper file depends on some EAL definitions. > Spotted with devtools/check-includes.sh: > error: implicit declaration of function ‘rte_eal_process_type’ > error: ‘RTE_PROC_PRIMARY’ undeclared > error: implicit declaration of function ‘rte_socket_id’ > > There was also this error because the inline keyword was missing: > error: ‘rte_event_pmd_pci_probe’ defined but not used > > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions > optional") > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> Spotted with devtools/check-includes.sh: That is a good reminder for people to add this to their patch workflow or to some automated tests. Acked-by: John McNamara <john.mcnam...@intel.com>
