-----Original Message----- > Date: Mon, 17 Jul 2017 17:09:47 +0100 > From: Harry van Haaren <[email protected]> > To: [email protected] > CC: Harry van Haaren <[email protected]>, > [email protected] > Subject: [PATCH] event: fix memory realloc check in port config > X-Mailer: git-send-email 2.7.4 > > This commit fixes the check to use the just reallocated > links_map variable, instead of stale dev->data->links_map. > Later the new variable is written to the dev->data->links_map, > so the stale-ness is only temporary. > > Coverity issue: 143456 > Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") > Cc: [email protected]
Reviewed-by: Jerin Jacob <[email protected]> > > Signed-off-by: Harry van Haaren <[email protected]> > --- > lib/librte_eventdev/rte_eventdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.c > b/lib/librte_eventdev/rte_eventdev.c > index ca2900c..bbb3805 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -298,7 +298,7 @@ rte_event_dev_port_config(struct rte_eventdev *dev, > uint8_t nb_ports) > sizeof(dev->data->links_map[0]) * nb_ports * > RTE_EVENT_MAX_QUEUES_PER_DEV, > RTE_CACHE_LINE_SIZE); > - if (dev->data->links_map == NULL) { > + if (links_map == NULL) { > dev->data->nb_ports = 0; > RTE_EDEV_LOG_ERR("failed to realloc mem for port_map," > "nb_ports %u", nb_ports); > -- > 2.7.4 >
