> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 18, 2017 10:24 PM > To: Liu, Changpeng <changpeng....@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user- > scsi sample application > > Hi, > > 15/07/2017 11:20, Changpeng Liu: > > --- /dev/null > > +++ b/examples/vhost_scsi/scsi_spec.h > > @@ -0,0 +1,488 @@ > > +/*- > > + * BSD LICENSE > > + * > > + * Copyright (c) Intel Corporation. > > + * All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions > > + * are met: > > + * > > + * * Redistributions of source code must retain the above copyright > > + * notice, this list of conditions and the following disclaimer. > > + * * Redistributions in binary form must reproduce the above copyright > > + * notice, this list of conditions and the following disclaimer in > > + * the documentation and/or other materials provided with the > > + * distribution. > > + * * Neither the name of Intel Corporation nor the names of its > > + * contributors may be used to endorse or promote products derived > > + * from this software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > CONTRIBUTORS > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > FITNESS FOR > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > COPYRIGHT > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > INCIDENTAL, > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > NOT > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > USE, > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND > ON ANY > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF > THE USE > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > DAMAGE. > > + */ > > + > > +#ifndef _SCSI_SPEC_H > > +#define _SCSI_SPEC_H > > This file is full of specification values. > Ideally it should be included from somewhere else. > If not possible, please add a comment in this file to explain where > it comes from. Is it copied from other projects?
As I know, Linux has one library iscsi-devel contains some definition of the SCSI specification, again the library is not good enough, so I reuse the code from SPDK(https://github.com/spdk/spdk, BSD licensed). > Is there a link to the specification? Please find the link to the SCSI Primary Commands 3 and SCSI Block Commands 3 specifications from the following link: http://www.t10.org/drafts.htm#SPC_Family
