Hi > -----Original Message----- > From: Jan Blunck [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > Sent: Wednesday, July 12, 2017 8:59 PM > To: dev@dpdk.org > Cc: Doherty, Declan <declan.dohe...@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com> > Subject: [PATCH v2 3/4] cryptodev: rework PMD init to not require > rte_vdev.h > > The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. > By moving the helper to the header we don't require rte_vdev.h at build- > time of the librte_cryptodev library. This is a preparation to move the vdev > bus into a standalone library. > > Signed-off-by: Jan Blunck <jblu...@infradead.org>
I am seeing some clang errors when applying this patch: lib/librte_cryptodev/rte_cryptodev_vdev.h:88:14: error: implicit declaration of function 'rte_cryptodev_pmd_allocate' is invalid in C99 [-Werror,-Wimplicit-function-declaration] cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); ^ lib/librte_cryptodev/rte_cryptodev_vdev.h:88:12: error: incompatible integer to pointer conversion assigning to 'struct rte_cryptodev *' from 'int' [-Werror,-Wint-conversion] cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); Also, looks like git commit title is not correct, according to check-git-log.sh: Wrong headline format: cryptodev: rework PMD init to not require rte_vdev.h Pablo