> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Tuesday, July 11, 2017 8:42 AM
> To: Van Haaren, Harry <harry.van.haa...@intel.com>
> Cc: dev@dpdk.org; tho...@monjalon.net; Wiles, Keith <keith.wi...@intel.com>;
> Richardson,
> Bruce <bruce.richard...@intel.com>
> Subject: Re: [PATCH v4 2/7] service cores: EAL init changes
<snip>
> > + /* initialize default services configuration */
> > + uint32_t service_cores[RTE_MAX_LCORE];
> > + int count = rte_service_lcore_list(service_cores, RTE_MAX_LCORE);
> > + for (i = 0; i < count; i++)
> > + rte_service_lcore_start(service_cores[i]);
> > + ret = rte_service_set_default_mapping();
> > + if (ret) {
> > + rte_errno = ENOEXEC;
> > + return -1;
> > + }
>
> How about moving, rte_service_lcore_start() inside
> rte_service_set_default_mapping() so that rte_eal_init() level change will be
> less in linuxapp and bsdapp?(and both changes are tightly coupled too).
>
> You could change the function name to rte_service_enable_default_mapping()
> or something like that to include rte_service_lcore_start() start change.
Good idea - done. Does indeed make things cleaner - thanks!
> With that change:
> Acked-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>
Added to patch! Cheers, -Harry
