On 6/12/2017 10:38 AM, Shijith Thotton wrote: > Set UIO info device file operations open and release. Call pci reset > function inside open and release to clear device state at start and end. > Copied this behaviour from vfio_pci kernel module code. With this patch, > it is not mandatory to issue FLR by PMD's during init and close. > > Bus master enable and disable are added in open and release respectively > to take care of device DMA. > > Signed-off-by: Shijith Thotton <shijith.thot...@caviumnetworks.com>
This patch, and Gregory's patch [1] are very similar and main target is to leave device in a more proper state when DPDK application quits unexpectedly. Difference between two are, this one implements both .open and .release ops, and sets / clears bus master accordingly. Although main concern is .reset, I am OK to follow vfio_pci approach here, and clearing bus master on .reset can prevent unwanted DMA access. So, I am for this patch and I am testing it for a few days without a problem. But Gregory reported a crash with older version of this patch, without more detail, we should clear that first. With Gregory's Tested-by, I am OK with this patch. Gregory, Are you using your version, what are the results? And would you mind testing this patch? Thanks, ferruh [1] http://dpdk.org/dev/patchwork/patch/25061/
