-----Original Message----- > Date: Thu, 6 Jul 2017 14:26:47 +0100 > From: "Hunt, David" <david.h...@intel.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com> > CC: dev@dpdk.org, harry.van.haa...@intel.com, Gage Eads > <gage.e...@intel.com>, Bruce Richardson <bruce.richard...@intel.com> > Subject: Re: [PATCH v5 1/3] examples/eventdev_pipeline: added sample app > User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 > Thunderbird/45.8.0 > > Hi Jerin, > > On 6/7/2017 11:04 AM, Hunt, David wrote: > > > > On 6/7/2017 4:31 AM, Jerin Jacob wrote: > > Having looked at this a bit more, and unable to reproduce with my original > kernel version checkpatch, and the patchwork version does not show, and the > 4.11.9 stable kernel version does not show, I suggest we mark these down as > false positives, as the string is not intended to show the function name. > > > > > I will give pull request Thomas on Friday morning. I will include > > > this change set > > > in the pull request. > > > > > > Regarding the performance drop, Can you add __rte_cache_aligned on those > > > variable which creates regression in moving to rte_malloc area. The > > > cache line could be shared? If not fixing then its fine we will look > > > into that latter. > > > > I will investigate and post a new patch in a few hours. > > > > Of the 4 variables I am attempting to move into fastpath structure, no > matter whether I move them one at a time or all at once, with > __rte_cache_align or not, I still see a significant performance degradation. > I suggest looking into this later. > > I will push a patch in the next couple of hours with the first two changes > mentioned above. OK with you?
OK. > > Regards, > Dave. > > > >
