05/07/2017 06:38, Shreyansh Jain: > Hello Thomas, > > On Wednesday 05 July 2017 05:43 AM, Thomas Monjalon wrote: > > Hi Shreyansh, > > > > 04/07/2017 16:43, Shreyansh Jain: > >> This patchset introduces the following: > >> 1. DPAA Bus (drivers/bus/dpaa) > >> The core of DPAA bus is implemented using 3 main hardware blocks: QMan, > >> or Queue Manager; BMan, or Buffer Manager and FMan, or Frame Manager. > >> The patches introduce necessary layers to expose the DPAA hardware > >> blocks for interfacing with RTE framework. > >> > >> 2. DPAA Mempool (drivers/mempool/dpaa) > >> BMan, or Buffer Manager, block of DPAA features a hardware offloaded > >> mempool. These patches add support for a driver to manage the BMan > >> block. This driver allows for mempool creation, deletion, buffer > >> acquire and release, as per the RTE APIs. > >> > >> 3. DPAA PMD (drivers/net/dpaa) > >> The Poll Mode Driver for DPAA NIC Interfaces. > > > > There is so much to review in this series! > > (and not much reviews) > > I hope you were not expecting a quick integration. > > I understand this. > Ferruh has been putting in quite an effort - but yes, other than that, lack > of external review. > I am just expecting inputs - if there are none, then probably that would be > integration point (other than continuous improvements we do internally) or > patches might stagnate. > > But just a random thought off my head (which might help me as a reviewer): > How does one review integral/infrastructure related code blocks without a > deep insight? ethdev/rxtx are relatively much easier/relevant for reviewers - > but not low level blocks. In case of DPAA, that (core routines) is a huge > chunks. And, if there are not much reviews (because of lack of interest, or > whatever reason), what should an author do (besides gently requesting others, > and doing some himself/herself).
I guess nobody will review the low level. But we can check how it is integrated within the framework. > > Please could you start checking what checkpatch is saying? > > > > I have seen those - and ignored them for a while. They are related to complex > statements defined as macros. Unfortunately, at some of the places, I can't > avoid it. > Otherwise, there are some which require code-restructuring (deep > indentation), which I plan to do shortly. Thanks
