[dpdk-dev] [PATCH v2] net/bonding: support bifurcated driver in eal cli using --vdev

[Gowrishankar]

From: Gowrishankar Muthukrishnan <gowrishanka...@linux.vnet.ibm.com>

At present, creating bonding devices using --vdev is broken for PMD like
mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown
to find_port_id_by_pci_addr(), as below.

testpmd <EAL args> --vdev 'net_bonding0,mode=1,slave=<PCI>,socket_id=0'

PMD: bond_ethdev_parse_slave_port_kvarg(150) - Invalid slave port value
 (<PCI ID>) specified
EAL: Failed to parse slave ports for bonded device net_bonding0

This patch fixes parsing PCI ID from bonding device params by verifying
it in RTE PCI bus, rather than checking dev->kdrv.

Changes:
  v2 - revisit fix by iterating rte_pci_bus
  
Signed-off-by: Gowrishankar Muthukrishnan <gowrishanka...@linux.vnet.ibm.com>
---
 drivers/net/bonding/rte_eth_bond_args.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_args.c 
b/drivers/net/bonding/rte_eth_bond_args.c
index c718e61..180586c 100644
--- a/drivers/net/bonding/rte_eth_bond_args.c
+++ b/drivers/net/bonding/rte_eth_bond_args.c
@@ -40,6 +40,8 @@
 #include "rte_eth_bond.h"
 #include "rte_eth_bond_private.h"
 
+extern struct rte_pci_bus rte_pci_bus;
+
 const char *pmd_bond_init_valid_arguments[] = {
        PMD_BOND_SLAVE_PORT_KVARG,
        PMD_BOND_PRIMARY_SLAVE_KVARG,
@@ -59,16 +61,6 @@
        unsigned i;
 
        for (i = 0; i < rte_eth_dev_count(); i++) {
-
-               /* Currently populated by rte_eth_copy_pci_info().
-                *
-                * TODO: Once the PCI bus has arrived we should have a better
-                * way to test for being a PCI device or not.
-                */
-               if (rte_eth_devices[i].data->kdrv == RTE_KDRV_UNKNOWN ||
-                   rte_eth_devices[i].data->kdrv == RTE_KDRV_NONE)
-                       continue;
-
                pci_dev = RTE_ETH_DEV_TO_PCI(&rte_eth_devices[i]);
                eth_pci_addr = &pci_dev->addr;
 
@@ -103,12 +95,18 @@
 static inline int
 parse_port_id(const char *port_str)
 {
+       struct rte_pci_device *dev;
        struct rte_pci_addr dev_addr;
-       int port_id;
+       int port_id = -1;
 
        /* try parsing as pci address, physical devices */
        if (eal_parse_pci_DomBDF(port_str, &dev_addr) == 0) {
-               port_id = find_port_id_by_pci_addr(&dev_addr);
+               FOREACH_DEVICE_ON_PCIBUS(dev) {
+                       if (rte_eal_compare_pci_addr(&dev->addr, &dev_addr))
+                               continue;
+
+                       port_id = find_port_id_by_pci_addr(&dev_addr);
+               }
                if (port_id < 0)
                        return -1;
        } else {
-- 
1.9.1