> -----Original Message----- > From: Doherty, Declan > Sent: Tuesday, July 4, 2017 10:43 AM > To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> > Cc: dev@dpdk.org; Gonzalez Monroy, Sergio > <sergio.gonzalez.mon...@intel.com> > Subject: Re: [PATCH v3 1/4] crypto/aesni_gcm: migrate to Multi-buffer > library > > On 04/07/17 01:12, Pablo de Lara wrote: > > Since Intel Multi Buffer library for IPSec has been updated to support > > Scatter Gather List, the AESNI GCM PMD can link to this library, > > instead of the ISA-L library. > > > > This move eases the maintenance of the driver, as it will use the same > > library as the AESNI MB PMD. > > It also adds support for 192-bit keys. > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com> > > Signed-off-by: Sergio Gonzalez Monroy > > <sergio.gonzalez.mon...@intel.com> > > --- > > devtools/test-build.sh | 4 +- > > doc/guides/cryptodevs/aesni_gcm.rst | 53 ++++++++--- > > doc/guides/cryptodevs/features/aesni_gcm.ini | 4 +- > > doc/guides/rel_notes/release_17_08.rst | 8 ++ > > drivers/crypto/aesni_gcm/Makefile | 9 +- > > drivers/crypto/aesni_gcm/aesni_gcm_ops.h | 97 > ++++++++++++++++++-- > > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 111 > +++++++++++++---------- > > drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 14 ++- > > drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h | 28 +++--- > > mk/rte.app.mk | 3 +- > > 10 files changed, 238 insertions(+), 93 deletions(-) > > > > diff --git a/devtools/test-build.sh b/devtools/test-build.sh index > > 079c8b8..c6dfaf0 100755 > > --- a/devtools/test-build.sh > > +++ b/devtools/test-build.sh > > @@ -38,7 +38,6 @@ default_path=$PATH > > # - DPDK_BUILD_TEST_CONFIGS (defconfig1+option1+option2 > defconfig2) > > # - DPDK_DEP_ARCHIVE > > # - DPDK_DEP_CFLAGS > > -# - DPDK_DEP_ISAL_CRYPTO (y/[n]) > > # - DPDK_DEP_LDFLAGS > > # - DPDK_DEP_MOFED (y/[n]) > > # - DPDK_DEP_NUMA ([y]/n) > > @@ -121,7 +120,6 @@ reset_env () > > unset CROSS > > unset DPDK_DEP_ARCHIVE > > unset DPDK_DEP_CFLAGS > > - unset DPDK_DEP_ISAL_CRYPTO > > unset DPDK_DEP_LDFLAGS > > unset DPDK_DEP_MOFED > > unset DPDK_DEP_NUMA > > @@ -182,7 +180,7 @@ config () # <directory> <target> <options> > > sed -ri 's,(PMD_ARMV8_CRYPTO=)n,\1y,' $1/.config > > test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \ > > sed -ri 's,(PMD_AESNI_MB=)n,\1y,' $1/.config > > - test "$DPDK_DEP_ISAL_CRYPTO" != y || \ > > + test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \ > > sed -ri 's,(PMD_AESNI_GCM=)n,\1y,' $1/.config > > test -z "$LIBSSO_SNOW3G_PATH" || \ > > sed -ri 's,(PMD_SNOW3G=)n,\1y,' $1/.config > > diff --git a/doc/guides/cryptodevs/aesni_gcm.rst > > b/doc/guides/cryptodevs/aesni_gcm.rst > > index 84cdc52..591c0b1 100644 > > --- a/doc/guides/cryptodevs/aesni_gcm.rst > > +++ b/doc/guides/cryptodevs/aesni_gcm.rst > > @@ -1,5 +1,5 @@ > > .. BSD LICENSE > > - Copyright(c) 2016 Intel Corporation. All rights reserved. > > + Copyright(c) 2016-2017 Intel Corporation. All rights reserved. > > > > Redistribution and use in source and binary forms, with or without > > modification, are permitted provided that the following > > conditions @@ -32,8 +32,8 @@ AES-NI GCM Crypto Poll Mode Driver > > > > > > The AES-NI GCM PMD (**librte_pmd_aesni_gcm**) provides poll mode > > crypto driver -support for utilizing Intel ISA-L crypto library, which > > provides operation acceleration -through the AES-NI instruction sets for > AES-GCM authenticated cipher algorithm. > > +support for utilizing Intel multi buffer library (see AES-NI > > +Multi-buffer PMD documentation to learn more about it, including > installation). > > > > Features > > -------- > > @@ -49,19 +49,51 @@ Authentication algorithms: > > * RTE_CRYPTO_AUTH_AES_GCM > > * RTE_CRYPTO_AUTH_AES_GMAC > > > > AES GCM should be listed under AEAD algorithms now > > > +Limitations > > +----------- > > > > Acked-by: Declan Doherty <declan.dohe...@intel.com> >
Hi, Will fix the documentation when merging the patch. Thanks for the review! Pablo
