Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, July 3, 2017 12:19 PM
> To: Iremonger, Bernard <bernard.iremon...@intel.com>; Shrikrishna Khare
> <skh...@vmware.com>
> Cc: Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process API
>
> On 7/3/2017 12:06 PM, Iremonger, Bernard wrote:
> > Hi Ferruh,
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Monday, July 3, 2017 10:05 AM
> >> To: Iremonger, Bernard <bernard.iremon...@intel.com>; Shrikrishna
> >> Khare <skh...@vmware.com>
> >> Cc: Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process
> >> API
> >>
> >> On 7/3/2017 10:01 AM, Ferruh Yigit wrote:
> >>> On 7/1/2017 4:19 PM, Thomas Monjalon wrote:
> >>>> 15/06/2017 14:29, Bernard Iremonger:
> >>>>> From: "Bernard.Iremonger" <bernard.iremon...@intel.com>
> >>>>>
> >>>>> Change the rte_eth_dev_callback_process function to return int,
> >>>>> and add a void *ret_param parameter.
> >>>>
> >>>> Adding this explanation:
> >>>> The new parameter is used by ixgbe and i40e instead of abusing
> >>>> the user data of the callback.
> >>>> and this title:
> >>>> ethdev: add return values to callback process API
> >>>>
> >>>> And applied, thanks
> >>>>
> >>>
> >>> Hi Bernard, Shrikrishna,
> >>>
> >>> This patch breaks vmxnet3 build, can you please send a patch to fix it?
> >>
> >> The build error is on next-net. Main repo looks good.
> >>
> >>>
> >>> Thanks,
> >>> ferruh
> >>>
> >
> > In dpdk-next-net a call to _rte_eth_dev_callback_process() has been
> added in vmxnet3_ethdev.c at line 1321 using the old API.
> > I can send a patch or could you add an extra NULL parameter at line 1325 in
> vmxnet3_ethdev.c?
>
> Fix is trivial, but I shouldn't just update the code. It should be done by a
> proper process, with a fix patch.
>
> Would you mind sending the patch?
>
> Thanks,
> ferruh
>
> >
> > Regards,
> >
> > Bernard.
> >
I can send the patch, however I am seeing the following build error on the dpdk
and dpdk-next-net at present:
CC eal_interrupts.o
/root/dpdk_sforge_origin/lib/librte_eal/linuxapp/eal/eal_memory.c:58:18: fatal
error: numa.h: No such file or directory
#include <numa.h>
^
compilation terminated.
Are you seeing this error?
Regards,
Bernard.
