On 6/29/2017 5:13 PM, Ferruh Yigit wrote: <...> >> 3. From a patchset split point of view, could this set be split up to be >> a bit more granular. There are a lot of functions to be performed on >> NICs called out in the code, e.g. start/stop, get stats, etc. etc. To >> make review easier, should we initially add the kernel module and >> userspace parts with just one function supported, and then add in each >> additional function in a new patchset, so that we can clearly see the >> code for each function isolated from the rest. This is the approach - >> adding feature by feature - that is recommended for NIC drivers, and it >> might make sense here too. > > Let me try to split patches more.
Done, sent v9, patchset split into more patches. > >> >> Otherwise, great work. I think this is a huge improvement in usability >> for DPDK, especially if we add in future support for controlling DPDK >> interfaces in a (not interfering with the app) safe manner too. >> >> /Bruce >> >
