Hi Beilei,
> -----Original Message-----
> From: Xing, Beilei
> Sent: Wednesday, June 28, 2017 7:58 AM
> To: Chilikin, Andrey <andrey.chili...@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing...@intel.com>
> Subject: RE: [PATCH v3 1/2] net/i40e: extended list of operations for ddp
> processing
>
> Hi Andrey,
>
<snip>
> > + }
> > + else {
>
> Should be } else { here according to the coding style.
Will fix in v4
> > --- a/drivers/net/i40e/rte_pmd_i40e.h
> > +++ b/drivers/net/i40e/rte_pmd_i40e.h
> > @@ -71,6 +71,8 @@ struct rte_pmd_i40e_mb_event_param { enum
> > rte_pmd_i40e_package_op {
> > RTE_PMD_I40E_PKG_OP_UNDEFINED = 0,
> > RTE_PMD_I40E_PKG_OP_WR_ADD, /**< load package and add to
> > info list */
> > + RTE_PMD_I40E_PKG_OP_WR_DEL, /**< load package and delete
> > from info list */
> > + RTE_PMD_I40E_PKG_OP_WR_ONLY, /**< load package without
> > modifying info
> > +list */
>
> The only difference between RTE_PMD_I40E_PKG_OP_WR_ADD and
> RTE_PMD_I40E_PKG_OP_WR_ONLY is if need to change info list, right? Is there
> any difference between the profiles added? Do we need another CLI in testpmd
> to indicate how/when we need to use RTE_PMD_I40E_PKG_OP_WR_ONLY?
>
I believe that existing testpmd CLI is enough for i40e as this 'if' statement
if (track_id && (op != RTE_PMD_I40E_PKG_OP_WR_ONLY)) {
will not register profiles with track_id == 0
> Beilei
Regards,
Andrey
