27/06/2017 11:51, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 23/06/2017 14:52, Declan Doherty: > > > On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > > > Move all functions handling virtual devices to a separate header > > > > file "rte_cryptodev_vdev.h", in order to leave only generic > > > > functions for any device in the rest of the files. > > > > > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com> > > > > > > Acked-by: Declan Doherty <declan.dohe...@intel.com> > > > > This patch is moving some code from a .c to a .h. > > The consequence is that driver are now compiling new functions from the .h > > and require librte_kvargs to link with. > > It is a build error in shared lib mode. > > > > Please keep the code in a .c file if possible. > > Sorry about this. I just fixed it in the subtree, so pull it whenever you are > ready. > Also, since ethdev have separated pci and vdev functions in separate .h files, > I preferred to be consistent and do the same.
There is no reason to implement these functions in .h files. I prefer to keep them in a .c file and just export the proto in .h.
