On Tue, 2017-06-27 at 01:22 +0200, Thomas Monjalon wrote:
> 23/06/2017 20:41, lbocc...@brocade.com:
> > From: Luca Boccassi <luca.bocca...@gmail.com>
> > 
> > In order to achieve reproducible builds, always check dependencies
> > in
> > the same order.
> > 
> > Signed-off-by: Luca Boccassi <luca.bocca...@gmail.com>
> > ---
> >  mk/internal/rte.compile-pre.mk | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> It seems something is missing in this patch,
> because it is always rebuilding all on the second build.

Indeed, thanks for spotting my mistake!

Sorting before comparing was changing the compared strings, so that was
not working. Duh!
Moving the sort as the "outer" call solves the problem, now rebuilds
correctly skip already built objects.

-- 
Kind regards,
Luca Boccassi

Reply via email to